(Towards #2577) Add pointer and target attributes in datatypes, frontend and backend
#2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ureType.ComponentType`, frontend and backend. NOTE: tests not done.
…nstead of Symbols. Some tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2822 +/- ##
==========================================
- Coverage 99.88% 99.88% -0.01%
==========================================
Files 357 357
Lines 49742 49960 +218
==========================================
+ Hits 49686 49903 +217
- Misses 56 57 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts implementing point 2 of Sergi's list in #2577 by adding new attributes to datatypes, as well as frontend and backend support for them.
Note that
is_potentially_aliasedis not used anywhere, except to fix an existingMatmul2CodeTranstest.So this does not check for aliasing anywhere else for now. Stated differently, this might be dangerous to merge as it effectively supports pointers in PSyIR but does not yet restrict transformations to non-aliased variables.